Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed COMPILED.pdf and updated PDF layout #1755

Merged
merged 8 commits into from
Aug 24, 2024

Conversation

emko-274
Copy link
Contributor

@emko-274 emko-274 commented Aug 23, 2024

  • added 50px margin to PDF forms
  • moved "Assumptions" block under "Disclaimer" in summary PDF

to-do:

  • update build_zip form filling tests
  • add clear button test to search panel test file

@emko-274 emko-274 requested a review from wittejm August 23, 2024 19:09
@wittejm
Copy link
Contributor

wittejm commented Aug 23, 2024

Why did you have to modify the stylesheet?

@emko-274
Copy link
Contributor Author

Michael requested that we add a bigger margin to the PDF files, which I did by modifying the stylesheet.

@wittejm
Copy link
Contributor

wittejm commented Aug 24, 2024 via email

@wittejm
Copy link
Contributor

wittejm commented Aug 24, 2024 via email

@emko-274
Copy link
Contributor Author

Yes, the new file just contains the text from the source that was originally being requested from (https://raw.githubusercontent.com/sindresorhus/github-markdown-css/gh-pages/github-markdown.css), with a one-line edit. Is it alright if I add the comment in the file where the new one is read from? I'm not sure how to write comments in the txt file so that they aren't read into the string that's supposed to contain only CSS, other than by skipping lines when reading, which I think might be awkward.

@wittejm
Copy link
Contributor

wittejm commented Aug 24, 2024 via email

@emko-274
Copy link
Contributor Author

Okay, I added the comment

@emko-274 emko-274 merged commit 4c981dd into codeforpdx:master Aug 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants