-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed COMPILED.pdf and updated PDF layout #1755
Conversation
Why did you have to modify the stylesheet? |
Michael requested that we add a bigger margin to the PDF files, which I did by modifying the stylesheet. |
And you're customizing the stylesheet that we were downloading from
somewhere?
…On Fri, Aug 23, 2024, 5:59 PM emko-274 ***@***.***> wrote:
Michael requested that we add a bigger margin to the PDF files, which I
did by modifying the stylesheet.
—
Reply to this email directly, view it on GitHub
<#1755 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQB5HQ4WFVTO54PMUE5ZM3ZS7LH5AVCNFSM6AAAAABNAWKB56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3DMOJQGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
It was surprising to see such a large new file. I think that comments in
the file mentioning where it came from, and noting the change you made from
the original, would be helpful
…On Fri, Aug 23, 2024, 6:01 PM Jordan Witte ***@***.***> wrote:
And you're customizing the stylesheet that we were downloading from
somewhere?
On Fri, Aug 23, 2024, 5:59 PM emko-274 ***@***.***> wrote:
> Michael requested that we add a bigger margin to the PDF files, which I
> did by modifying the stylesheet.
>
> —
> Reply to this email directly, view it on GitHub
> <#1755 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAQB5HQ4WFVTO54PMUE5ZM3ZS7LH5AVCNFSM6AAAAABNAWKB56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3DMOJQGE>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
Yes, the new file just contains the text from the source that was originally being requested from (https://raw.githubusercontent.com/sindresorhus/github-markdown-css/gh-pages/github-markdown.css), with a one-line edit. Is it alright if I add the comment in the file where the new one is read from? I'm not sure how to write comments in the txt file so that they aren't read into the string that's supposed to contain only CSS, other than by skipping lines when reading, which I think might be awkward. |
Ah, that's why it's a txt file. Yea, explaining it and showing the URL in
the comment when you call the file sounds good
…On Fri, Aug 23, 2024, 6:23 PM emko-274 ***@***.***> wrote:
Yes, the new file just contains the text from the source that was
originally being requested from (
https://raw.githubusercontent.com/sindresorhus/github-markdown-css/gh-pages/github-markdown.css),
with a one-line edit. Is it alright if I add the comment in the file where
the new one is read from? I'm not sure how to write comments in the txt
file so that they aren't read into the string that's supposed to contain
only CSS, other than by skipping lines when reading, which I think might be
awkward.
—
Reply to this email directly, view it on GitHub
<#1755 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQB5HVZQ6BXAWNZCZJNY6DZS7OC3AVCNFSM6AAAAABNAWKB56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBXHE3TMMZZGA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Okay, I added the comment |
…tement in markdown_to_pdf.py
to-do: