Refactored and removed 6 smells #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ariable and Decompose Conditional
…rate strategy class (DocumentMergeStrategy).
…with polymorphism
…with polymorphism
…with polymorphism
|
This is quite good, but doesn't pass our checkstyle 😕 Can you please make sure the coding guidelines are followed? This also ensures the diff is smaller and readable |
|
Also, can you please remove all the extra html report files? They should not be in the codebase. |
|
I've activated the continuous integration to run on pull requests now, so hopefully when you check in your adaptations SemaphoreCI will tell you whether the checkstyle criteria is met, also whether anything is breaking post the change. You should see the results, after you updated your PR, in https://codehaus-cargo.semaphoreci.com/projects/cargo. Don't get overwhelmed by the size of the pipeline, it "simply" does a build and many (over 2'500) tests 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.