Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Lua script to pop the task atomically #51

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Jan 7, 2025

Description
This PR ensures that tasks in Redis are taken off the queue atomically.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12828039111

Details

  • 38 of 40 (95.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 90.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Handlers/PredisHandler.php 14 15 93.33%
src/Handlers/RedisHandler.php 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
src/Handlers/RedisHandler.php 1 89.86%
Totals Coverage Status
Change from base Build 12647486320: -0.1%
Covered Lines: 534
Relevant Lines: 590

💛 - Coveralls

Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Lua so I'll trust you on this. 👍🏻

@michalsn michalsn merged commit 16fd35b into codeigniter4:develop Jan 17, 2025
19 checks passed
@michalsn
Copy link
Member Author

Thank you @paulbalandan and @samsonasik

@michalsn michalsn deleted the redis-lua-pop branch January 17, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants