Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php version ^8.2 #369

Closed
wants to merge 3 commits into from
Closed

php version ^8.2 #369

wants to merge 3 commits into from

Conversation

khagesh007
Copy link

No description provided.

@jonnott
Copy link
Contributor

jonnott commented Jan 26, 2024

Doesn't this want to be..

"php": "^8.0.0|^8.1.0|^8.2.0"

..so 8.1.x is also still supported?

@khagesh007
Copy link
Author

yes @jonnott , I am updating my commit

@qschmick
Copy link
Collaborator

@khagesh007 Can you also update the GitHub action to run 8.2?

https://github.com/codestudiohq/laravel-totem/blob/9.0/.github/workflows/laravel.yml#L12

@khagesh007
Copy link
Author

@khagesh007 Can you also update the GitHub action to run 8.2?

https://github.com/codestudiohq/laravel-totem/blob/9.0/.github/workflows/laravel.yml#L12

Laravel.yml file updated

@jonnott
Copy link
Contributor

jonnott commented Mar 27, 2024

@khagesh007 This is now all included within #381 .. so you can probably close this PR and let's focus on the one with it all in..

@roshangautam

@roshangautam
Copy link
Collaborator

this was merged as part of @jonnott PR #381 Closing as this is now redundant. Appreciate your contribution efforts and sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants