Drop laravelcollective/html package (abandoned) #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move columnSort() into helpers.php and return HtmlString object directly, and drop TotemFormServiceProvider
- replace Form::{method}() calls with manual form markup
- update TestCase accordingly
jonnott
force-pushed
the
drop-laravelcollective-html
branch
from
2ef3787
to
814fac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency on the abandoned laravelcollective/html is the only thing preventing a new version with support for Laravel 11 and PHP 8.2+.
What's more, Totem doesn't really need it anyway..