Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #309 -- handle submit buttons form* attributes #310

Closed
wants to merge 5 commits into from

Conversation

gary02
Copy link

@gary02 gary02 commented Oct 14, 2024

Since form.submit API does not accept any arguments, we have to mutate form object.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gary02, this looks like an excellent start. Feel free to use Baseline2023 features, like let and const. This script hasn't been updated in a while, but there is no need to stick to ages old JS code ;)

s3file/static/s3file/js/s3file.js Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.37%. Comparing base (ee86db1) to head (9d41028).
Report is 16 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ee86db1) and HEAD (9d41028). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (ee86db1) HEAD (9d41028)
9 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #310       +/-   ##
===========================================
- Coverage   98.03%   81.37%   -16.67%     
===========================================
  Files           8        8               
  Lines         204      204               
===========================================
- Hits          200      166       -34     
- Misses          4       38       +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codingjoe
Copy link
Owner

Hi @gary02,

I actually invested some time to update this package to 2024 baseline features. Resulting in much less code, which in turns is also better testable.

I have a draft in #311. It should resolve your problem, since we simply resubmit the form with the same submitter.

@gary02
Copy link
Author

gary02 commented Oct 31, 2024

@codingjoe Great work! I close this PR

@gary02 gary02 closed this Oct 31, 2024
codingjoe added a commit that referenced this pull request Nov 11, 2024
* Drop custom upload progress events
* Update browser support to Baseline 2024
* Update Django version support
* Update Python version support
* Fix #310 -- Add `formaction` support on submit buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants