-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #309 -- handle submit buttons form*
attributes
#310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gary02, this looks like an excellent start. Feel free to use Baseline2023 features, like let and const. This script hasn't been updated in a while, but there is no need to stick to ages old JS code ;)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
===========================================
- Coverage 98.03% 81.37% -16.67%
===========================================
Files 8 8
Lines 204 204
===========================================
- Hits 200 166 -34
- Misses 4 38 +34 ☔ View full report in Codecov by Sentry. |
@codingjoe Great work! I close this PR |
* Drop custom upload progress events * Update browser support to Baseline 2024 * Update Django version support * Update Python version support * Fix #310 -- Add `formaction` support on submit buttons
Since form.submit API does not accept any arguments, we have to mutate
form
object.