Update rewards apis #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
facoinbase
force-pushed
the
fa/rewards-apis-update
branch
from
7c86eaa
to
0dc54f3
Compare
|
|
||
| amount := big.NewInt(0) | ||
|
|
||
| if model.GetAmount() != "" { |
There was a problem hiding this comment.
Is this because we are sometimes returning an empty value instead of a 0 value for a balance check?
There was a problem hiding this comment.
Exactly
unbondedBalance: 'Balance { amount: '' asset: 'Asset { networkId: '' assetId: '' contractAddress: '' decimals: '0' }' }
There was a problem hiding this comment.
AH makes sense, for solana its not a 0 value, but an nil one? If were just having the SDKs make nil -> 0, should we just return 0 from the API?
There was a problem hiding this comment.
I think making it nil on the api would be better
deangalvin-cb
previously requested changes
Sep 17, 2024
Align with api changes - StakingRewards's Date field is now a full timestamp - StakingBalance's Date field is now a full timestamp
facoinbase
force-pushed
the
fa/rewards-apis-update
branch
from
0dc54f3
to
9e2e6f1
Compare
cb-heimdall
dismissed
deangalvin-cb’s stale review
Approved review 2309739654 from deangalvin-cb is now dismissed due to new commit. Re-request for approval.
deangalvin-cb
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Align with api changes
Qualified Impact