Create constants for suported network names

[marcin-cb]

What changed? Why?

• Adding constants for supported network names
  • ethereum-holesky
  • ethereum-mainnet
  • solana-devnet
  • solana-mainnet

Qualified Impact

[cb-heimdall]

✅ Heimdall Review Status

Requirement	Status	More Info
Reviews	✅ 1/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 0 Sum 1

[drohit-cb]

should this be string(client.NETWORKIDENTIFIER_SOLANA_DEVNET) ?

[marcin-cb]

I don't have a strong preference here, but I was following the same convention from the NodeJS constant setup. It uses strings and does not link back to the API enums.

[drohit-cb]

I see the mapping happen here

Basically I would like to rely on the server side constants to define what the network ids need to look like instead of us defining it again here.

[marcin-cb]

Ah I misread that syntax. Yeah you're right. So then we may not need them entirely, however, the way the constants are setup in the generate files, it creates an all caps. So I'll keep them in and do what you suggested initially.

[drohit-cb]

Yup - the all caps thing is not great - plus its like a separate type - all our functions need a string networkID so doing string(client.NETWORKIDENTIFIER_SOLANA_DEVNET) makes the most sense to me.

[ProfMoo]

I like this idea 👍. I think Rohit's idea to limit the amount of "redefining" we do requires much less maintenance moving forward.