Merge pull request #188 from coinbase/patrick/verbose-client-error

[client] Verbose Response Type Error
coinbase · Oct 15, 2020 · 0605285 · 0605285
2 parents 978c228 + 80b7e97
commit 0605285
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/client/client.go b/client/client.go
@@ -20,7 +20,6 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io"
 	"log"
@@ -228,17 +227,20 @@ func (c *APIClient) decode(v interface{}, b []byte, contentType string) (err err
 	if len(b) == 0 {
 		return nil
 	}
+
 	if s, ok := v.(*string); ok {
 		*s = string(b)
 		return nil
 	}
+
 	if jsonCheck.MatchString(contentType) {
 		if err = json.Unmarshal(b, v); err != nil {
 			return err
 		}
 		return nil
 	}
-	return errors.New("undefined response type")
+
+	return fmt.Errorf("unsupported response content-type: %s body: %s", contentType, string(b))
 }
 
 // Set request body from an interface{}

diff --git a/templates/client/client.mustache b/templates/client/client.mustache
@@ -5,7 +5,6 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io"
 	"log"
@@ -209,17 +208,20 @@ func (c *APIClient) decode(v interface{}, b []byte, contentType string) (err err
 	if len(b) == 0 {
 		return nil
 	}
+
 	if s, ok := v.(*string); ok {
 		*s = string(b)
 		return nil
 	}
+
 	if jsonCheck.MatchString(contentType) {
 		if err = json.Unmarshal(b, v); err != nil {
 			return err
 		}
 		return nil
 	}
-	return errors.New("undefined response type")
+
+	return fmt.Errorf("unsupported response content-type: %s body: %s", contentType, string(b))
 }
 
 // Set request body from an interface{}