feat: improve some colors (#7)

colinlienard · Sep 18, 2023 · 4c4f26c · 4c4f26c
1 parent e130867
commit 4c4f26c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/src/colors.ts b/src/colors.ts
@@ -39,15 +39,15 @@ export const ui = {
 export const code = {
   foreground: '#9fabb1',
   comment: '#67747c',
-  string: '#d18e9b',
+  string: '#ce8694',
   variable: '#67b397',
   keyword: '#bb6473',
-  number: '#86be85',
+  number: '#85be8f',
   boolean: '#66abc7',
   operator: '#bfbfbf',
   function: '#d28677',
   constant: '#3d9b93',
-  parameter: '#cb9b97',
+  parameter: '#cb979a',
   class: '#bb6473',
   interface: '#9a88d2',
   type: '#8092d2',

diff --git a/src/theme.ts b/src/theme.ts
@@ -147,7 +147,7 @@ export function getTheme(name: string) {
       'editorCursor.foreground': ui.foreground,
 
       'editor.findMatchBackground': ui.backgroundBright,
-      'editor.findMatchHighlightBackground': ui.backgroundBright,
+      'editor.findMatchHighlightBackground': alpha(ui.primary, 50),
       'editor.linkedEditingBackground': ui.backgroundDark,
       'editor.inactiveSelectionBackground': ui.backgroundDark,
       'editor.selectionBackground': ui.backgroundLighter,
@@ -256,7 +256,7 @@ export function getTheme(name: string) {
       'editorBracketHighlight.foreground1': code.type,
       'editorBracketHighlight.foreground2': code.builtin,
       'editorBracketHighlight.foreground3': code.constant,
-      'editorBracketHighlight.unexpectedBracket.foreground': ui.foregroundDark,
+      'editorBracketHighlight.unexpectedBracket.foreground': ui.foreground,
 
       'editorError.foreground': ui.red,
       'editorWarning.foreground': ui.yellow,
@@ -421,7 +421,7 @@ export function getTheme(name: string) {
         },
       },
       {
-        scope: ['parameter', 'variable.parameter'],
+        scope: ['parameter', 'variable.parameter', 'support.constant.property-value.css'],
         settings: {
           foreground: code.parameter,
         },

diff --git a/themes/generated.json b/themes/generated.json
@@ -122,7 +122,7 @@
     "editorWhitespace.foreground": "#3B4043",
     "editorCursor.foreground": "#9fabb1",
     "editor.findMatchBackground": "#3B4043",
-    "editor.findMatchHighlightBackground": "#3B4043",
+    "editor.findMatchHighlightBackground": "#a75e5050",
     "editor.linkedEditingBackground": "#181818",
     "editor.inactiveSelectionBackground": "#181818",
     "editor.selectionBackground": "#333637",
@@ -174,7 +174,7 @@
     "editorBracketHighlight.foreground1": "#8092d2",
     "editorBracketHighlight.foreground2": "#d06678",
     "editorBracketHighlight.foreground3": "#3d9b93",
-    "editorBracketHighlight.unexpectedBracket.foreground": "#58656c",
+    "editorBracketHighlight.unexpectedBracket.foreground": "#9fabb1",
     "editorError.foreground": "#c16565",
     "editorWarning.foreground": "#d4af6f",
     "editorInfo.foreground": "#5696c4",
@@ -287,7 +287,7 @@
         "punctuation.definition.string.begin.markdown",
         "punctuation.definition.string.end.markdown"
       ],
-      "settings": { "foreground": "#d18e9b" }
+      "settings": { "foreground": "#ce8694" }
     },
     { "scope": ["invalid.deprecated.entity.other.attribute-name.html", "variable", "identifier"], "settings": { "foreground": "#67b397" } },
     {
@@ -304,7 +304,7 @@
       ],
       "settings": { "foreground": "#c7a18f" }
     },
-    { "scope": ["parameter", "variable.parameter"], "settings": { "foreground": "#cb9b97" } },
+    { "scope": ["parameter", "variable.parameter", "support.constant.property-value.css"], "settings": { "foreground": "#cb979a" } },
     { "scope": ["support.type.primitive", "entity.name.type", "support.function.misc"], "settings": { "foreground": "#8092d2" } },
     { "scope": ["namespace", "entity.name.namespace"], "settings": { "foreground": "#9a88d2" } },
     { "scope": ["keyword.operator.assignment.compound", "meta.var.expr.ts"], "settings": { "foreground": "#bfbfbf" } },
@@ -316,7 +316,7 @@
     { "scope": "message.error", "settings": {} },
     { "scope": ["source.regexp", "string.regexp"], "settings": { "foreground": "#bfbfbf" } },
     { "scope": "string.regexp constant.character.escape", "settings": {} },
-    { "scope": ["constant.numeric", "number"], "settings": { "foreground": "#86be85" } },
+    { "scope": ["constant.numeric", "number"], "settings": { "foreground": "#85be8f" } },
     { "scope": ["constant.language.boolean", "constant.language"], "settings": { "foreground": "#66abc7" } },
     { "scope": "meta.module-reference", "settings": {} },
     { "scope": "punctuation.definition.list.begin.markdown", "settings": {} },