Skip to content

Commit

Permalink
refactor(LineChart): change valueRadius prop name to valueBorderRadius
Browse files Browse the repository at this point in the history
BREAKING CHANGE: valueRadius prop name should be updated to valueBorderRadius
  • Loading branch information
colinmeinke committed Mar 16, 2016
1 parent fbeafd7 commit d5866bf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ const LineChart = ReactSVGChart.LineChart;
And if you just want to smash in a Javascript file you're
also covered. Drop this in place ...

[https://npmcdn.com/react-svg-chart@2.1.0/dist/react-svg-chart.min.js](https://npmcdn.com/react-svg-chart@2.1.0/dist/react-svg-chart.min.js)
[https://npmcdn.com/react-svg-chart@3.0.0/dist/react-svg-chart.min.js](https://npmcdn.com/react-svg-chart@3.0.0/dist/react-svg-chart.min.js)

Then access it on the `ReactSVGChart` global variable.

Expand Down
8 changes: 4 additions & 4 deletions src/LineChart.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ const LineChart = createClass({
preserveAspectRatio: PropTypes.string,
showLabels: PropTypes.bool,
title: PropTypes.string,
valueBorderRadius: PropTypes.number,
valueHeight: PropTypes.number,
valueOffset: PropTypes.number,
valueRadius: PropTypes.number,
valueWidth: PropTypes.number,
width: PropTypes.number,
},
Expand All @@ -37,9 +37,9 @@ const LineChart = createClass({
preserveAspectRatio: 'xMidYMid meet',
showLabels: true,
title: 'Line chart',
valueBorderRadius: 2,
valueHeight: 30,
valueOffset: 35,
valueRadius: 2,
valueWidth: 60,
width: 800,
};
Expand Down Expand Up @@ -157,8 +157,8 @@ const LineChart = createClass({
class="line-chart__value-bg"
fill="rgb( 255, 255, 255 )"
height={ this.props.valueHeight }
rx={ this.props.valueRadius }
ry={ this.props.valueRadius }
rx={ this.props.valueBorderRadius }
ry={ this.props.valueBorderRadius }
stroke="rgb( 0, 0, 0 )"
stroke-width="1"
width={ this.props.valueWidth }
Expand Down

0 comments on commit d5866bf

Please sign in to comment.