Improve coverage report #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9627060049Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9627068166Details
💛 - Coveralls |
stevepiercy
requested changes
Jun 22, 2024
niccokunzmann
changed the title
Pull Request Test Coverage Report for Build 9634087944Details
💛 - Coveralls |
|
coverage reporting works |
stevepiercy
approved these changes
Jun 24, 2024
|
I changed the description to represent the change. |
stevepiercy
approved these changes
Jun 25, 2024
|
@niccokunzmann I'll let you manage merging of PRs as it is a moving target for me and I reckon you have a better grip on it. |
|
I would like to you feel confident to merge. It is part of empowering contributors and spreading the load and increasing the bus factor, diversity, ... . Here are your documented rights: Please use them ❤️ |
|
Ah and most important: Merging makes people happy! And we have a version control system, so we do not really cause irreversible damage. Trust first if you ask me. |
niccokunzmann
added a commit
to niccokunzmann/icalendar
that referenced
this pull request
Jun 25, 2024
Sometimes, we get this error: coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs This PR allows the error to happen while also maintaining the test result and making sure that we actually installed all dependencies. This is a follow up from collective#644 main branch failed: https://github.com/collective/icalendar/actions/runs/9663149658/job/26654629821
niccokunzmann
added a commit
that referenced
this pull request
Jul 1, 2024
* Make coverage report optional in case it fails to submit Sometimes, we get this error: coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs This PR allows the error to happen while also maintaining the test result and making sure that we actually installed all dependencies. This is a follow up from #644 main branch failed: https://github.com/collective/icalendar/actions/runs/9663149658/job/26654629821 * log changes * use github service for coverage * Finalize coverage even if tests failed --------- Co-authored-by: Steve Piercy <web@stevepiercy.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use documented way to do coverage in parallel
Context: