Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the relation map dictionary #1076

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marpulli
Copy link

@marpulli marpulli commented May 3, 2023

This speeds up my local test suite from 2 minutes to 30 seconds in a project that uses ormar.

This addresses an issue similar to this #957

Copy link

codspeed-hq bot commented Mar 23, 2024

CodSpeed Performance Report

Merging #1076 will degrade performances by 23.09%

Comparing marpulli:speed-up (b97f5a5) with master (1ed0d5a)

Summary

⚡ 1 improvements
❌ 5 regressions
✅ 78 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master marpulli:speed-up Change
test_count[1000] 25 ms 21.3 ms +17.34%
test_max[250] 10.4 ms 13.4 ms -22.86%
test_min[1000] 12.7 ms 16.6 ms -23.09%
test_first[250] 10.2 ms 12.9 ms -20.91%
test_get_or_create_when_get[250] 10.2 ms 13.2 ms -22.93%
test_get_or_none[250] 10.3 ms 13.2 ms -21.66%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants