Removing relation child while updating nullable fk as None

[amit12297]

Fixes #1229

Removing relation child while updating nullable fk as None in descriptors.py->RelationDescriptor

Ran the test cases locally using pytest -svv --cov=ormar --cov=tests --cov-fail-under=100 --cov-report=term-missing

All test cases passed

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a206dd) 100.00% compared to head (57ab550) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #1230   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          201       201           
  Lines        16647     16659   +12     
=========================================
+ Hits         16647     16659   +12     

Files	Coverage Δ
ormar/models/descriptors/descriptors.py	100.00% <100.00%> (ø)
tests/test_relations/test_foreign_keys.py	100.00% <100.00%> (ø)

[collerek]

Hi,

Can you add a test that fails now and that this issue fixes?
Can be based on #1229 (without fastapi part, just ormar code is enough).
Please place it under tests/test_relations/test_foreign_keys.py as an additional test case.

[amit12297]

Hi,

Can you add a test that fails now and that this issue fixes? Can be based on #1229 (without fastapi part, just ormar code is enough). Please place it under tests/test_relations/test_foreign_keys.py as an additional test case.

Hi @collerek,

I added the test-case. It fails without my changes and is passing with my changes. Please suggest if I can give a better name to the test-case.

Here are the screenshots-

Failing without my changes:

Passed with my changes:

[amit12297]

@collerek please merge this if everything looks fine

[codspeed-hq]

CodSpeed Performance Report

Merging #1230 will degrade performances by 23.48%

_{Comparing amit12297:fix-fk-null-update (57ab550) with master (3a206dd)}

Summary

❌ 1 regressions
✅ 83 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	master	amit12297:fix-fk-null-update	Change
❌	test_get_or_none[250]	10 ms	13.1 ms	-23.48%