event emitter: copy list of callbacks before iterating. closes #51

colyseus · Jan 31, 2024 · 022fcf6 · 022fcf6
1 parent 99ed590
commit 022fcf6
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/colyseus/eventemitter.lua b/colyseus/eventemitter.lua
@@ -68,7 +68,14 @@ function EventEmitter:new(object)
   end
 
   function object:emit (event, ...)
-    for _, listener in ipairs(self:listeners(event)) do
+    -- copy list before iterating over it
+    -- (make sure all previously registered callbacks are called, even if some are removed in-between)
+    local listeners = {}
+    for i, listener in ipairs(self:listeners(event)) do
+      listeners[i] = listener
+    end
+
+    for i, listener in ipairs(listeners) do
       if "function" == type(listener) then
         listener(...)