Car Port: Kia Carnival HEV 2025 (HDA2)

[ccdunder]

Checklist

• added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
• test route added to routes.py
• route with openpilot: 6c0069dcd5bbb6c1/00000020--6b95507969
• route with stock system: 6c0069dcd5bbb6c1/00000021--e6c25dde2d
• car harness used (if comma doesn't sell it, put N/A): Hyundai Q

Dependencies:

• Car Port: Kia Carnival HEV 2025 (HDA2) panda#2109

Changes:

1. Adds new car KIA_CARNIVAL_HEV_4TH_GEN. This is the first year the Carnival is available as a hybrid. At the very least the mass is different. Who knows what else. And this follows the apparent convention here to declare HEV versions separately from their ICE siblings.
2. Fixes can error by adding support for ALT_BUTTONS to HDA2. Otherwise, the following error is logged continuously and can never becomes valid:

   "filename": "opendbc_repo/opendbc/can/parser.cc",
   "funcname": "UpdateValid",
   "levelnum": 40,
   "lineno": ' '230,
   "msg": "0x1CF \'CRUISE_BUTTONS\' NOT SEEN"}',
   

3. Fixes lane change detection by adding support for ALT_LAMPS.
4. Fixes cruise resume from standstill by adding support for ALT_BUTTONS.

Parent PR: commaai/openpilot#34246

[github-actions]

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • include a route or your device' dongle ID if relevant

[sunnyhaibin]

This PR is a duplicate of #1558.

[ccdunder]

This PR is a duplicate of #1558.

Sure, the titles are similar but the content is very different. #1558 appears to be a stale draft with fingerprints only. This PR has fixes, routes, and has been verified to work.

[jyoung8607]

Disclaimer: While I have the ability to merge one of these PRs, I don't set bounty policy or make bounty decisions.

@ccdunder: Welcome to opendbc and openpilot! We like having new contributors. That said, if you're aware there are other potentially duplicate PRs, it's good practice to explicitly mention them and explain why it's necessary to file a separate one. I wouldn't really call that other PR stale, conversations and testing are clearly in progress.

@sunnyhaibin: Haven't reviewed these in depth, but there are definitely differences between these PRs, starting with the existence of Panda changes in this one. Neither of these PRs are ready to merge. To get one of them merge-ready, this would be a great time to onboard and collaborate with a first-time contributor and HKG owner.

[ccdunder]

@sunnyhaibin my sincere apologies for my overly critical reply. I heard what sounded like "we don't want your work" and got confused and defensive. My sincere thanks @jyoung8607 for the warm welcome and cool moderation 🙏 Jason and I are collaborating in discord now.

To avoid duplicating efforts, I'm going to focus this set of PRs on the HEV specifically (i.e. drop the ICE fingerprints). There is an additional issue that only affects the ICE model and I only have an HEV to verify with anyhow.