Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulator: add_bridge_test #32102

Closed
wants to merge 7 commits into from
Closed

simulator: add_bridge_test #32102

wants to merge 7 commits into from

Conversation

StefanLekanic-SYRMIA
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@StefanLekanic-SYRMIA StefanLekanic-SYRMIA changed the title try after simulator repair simulator: add_bridge_test Apr 4, 2024
@StefanLekanic-SYRMIA
Copy link
Contributor Author

#31759

@StefanLekanic-SYRMIA
Copy link
Contributor Author

Navd is crashing all the time...

@mimi89999
Copy link
Contributor

What framerate are you getting in MetaDrive on GH Actions?

@StefanLekanic-SYRMIA
Copy link
Contributor Author

StefanLekanic-SYRMIA commented Apr 9, 2024

https://github.com/commaai/openpilot/actions/runs/8552729312/job/23434461222?pr=32102
@mimi89999 I can't see framerate... i get message "vipc_client_main no frame"...

@StefanLekanic-SYRMIA
Copy link
Contributor Author

StefanLekanic-SYRMIA commented Apr 9, 2024

When i run it locally, it has the same behaviour, but i can see the framerate. It starts from 14.88, and falling to the 8.40, at the end...
Screenshot from 2024-04-09 12-00-05

@mimi89999
Copy link
Contributor

Run export BLOCK="mapsd,navd" before launching ./tools/sim/launch_openpilot.sh. Then OP should start.

@mimi89999
Copy link
Contributor

Have you tried running the test from #30693 (comment) ?

@StefanLekanic-SYRMIA
Copy link
Contributor Author

StefanLekanic-SYRMIA commented Apr 9, 2024

@mimi89999 it works definitely, i blocked just navd in 86edf77, and it was working smoothly... but in #31125 is mentioned that no proccesses can be blocked...

@StefanLekanic-SYRMIA
Copy link
Contributor Author

Have you tried running the test from #30693 (comment) ?

No i didn't... i will try

@StefanLekanic-SYRMIA
Copy link
Contributor Author

Hi @jnewb1 , is there any possible problem again in simulator, with navd... Before simulator repair it was working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants