common: add ParameterUpdater for thread-safe parameter updates #34186
+81
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanlee
force-pushed
the
card_add_ParamsUpdater
branch
3 times, most recently
from
963b0b2 to
4a6a539
Compare
deanlee
changed the title
deanlee
changed the title
deanlee
force-pushed
the
card_add_ParamsUpdater
branch
3 times, most recently
from
8dc6df5 to
ff659a1
Compare
deanlee
changed the title
deanlee
force-pushed
the
card_add_ParamsUpdater
branch
5 times, most recently
from
5a29cd6 to
76b212f
Compare
deanlee
force-pushed
the
card_add_ParamsUpdater
branch
from
76b212f to
d7400d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GIL does not protect against race conditions when accessing attributes like self.is_metric across multiple threads. This PR introduces the
ParameterUpdaterclass, which periodically updates parameters in a separate thread and ensures safe access through a mutex.It also resolves a potential race condition in
selfdrivedby ensuring that parameters likeself.CP.openpilotLongitudinalControlare accessed only in the main thread.it's currently used in
selfdrivedandcard, and can be extended to other modules requiring updated parameters.