replay: fix various synchronization and event handling issues #34254
+62
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
std::shared_ptr
access usingstd::atomic_load
andstd::atomic_store
to ensure thread-safe reads and writes.Cabana
'sSlider::paintEvent
.Cabana
.onSegmentsMerged
callback is fully finished to prevent data inconsistencies.mutex
andcondition_variable
to wait for the queued slot function to finish, ensuring it stays in sync with the replay'shandleSegmentMerge
thread.timeline.h
for better readability.