Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabana: fix crash in live streaming mode by skipping thumbnail display #34302

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Dec 22, 2024

This issue was introduced by #34301.
In live streaming mode, there is no video widget or slider bar, which causes a crash when attempting to display thumbnails. This PR resolves the issue by skipping the thumbnail display function when live streaming mode is active.

@github-actions github-actions bot added the tools label Dec 22, 2024
@adeebshihadeh adeebshihadeh merged commit 52c8a12 into commaai:master Dec 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants