Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename IN.todo to IN.yaml #477

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nishantnathhoney
Copy link

Adding "fixed" holidays for India

https://en.wikipedia.org/wiki/Public_holidays_in_India

@commenthol
Copy link
Owner

Hi @nishantnathhoney,
thanks for your contribution.
You can find the meanings of the tags used in the yaml files under docs/specification.md
_name is a reference to a tag in names.yaml and needs to be updated.
Maybe you'd like to consider my proposed:

holidays:
  # @source https://en.wikipedia.org/wiki/Public_holidays_in_India
  IN:
    names:
      en: India
    langs:
      - hi
      - en
    zones:
      - Asia/Kolkata
    dayoff: ''
    days:
      01-26:
        name: 
          en: Republic Day
      08-15:
        _name: Independence Day
      10-02:
        name: 
          en: Gandhi Jayanti
    # states:
    #   AN:
    #     name: Andaman and Nicobar Islands
    #   AP:
    #     name: Andhra Pradesh
    #   AR:
    #     name: Arunachal Pradesh
    #   AS:
    #     name: Assam
    #   BR:
    #     name: Bihar
    #   CH:
    #     name: Chandigarh
    #   CT:
    #     name: Chhattisgarh
    #   DD:
    #     name: Daman and Diu
    #   DL:
    #     name: Delhi
    #   DN:
    #     name: Dadra and Nagar Haveli
    #   GA:
    #     name: Goa
    #   GJ:
    #     name: Gujarat
    #   HP:
    #     name: Himachal Pradesh
    #   HR:
    #     name: Haryana
    #   JH:
    #     name: Jharkhand
    #   JK:
    #     name: Jammu and Kashmir
    #   KA:
    #     name: Karnataka
    #   KL:
    #     name: Kerala
    #   LD:
    #     name: Lakshadweep
    #   MH:
    #     name: Maharashtra
    #   ML:
    #     name: Meghalaya
    #   MN:
    #     name: Manipur
    #   MP:
    #     name: Madhya Pradesh
    #   MZ:
    #     name: Mizoram
    #   NL:
    #     name: Nagaland
    #   OR:
    #     name: Odisha
    #   PB:
    #     name: Punjab
    #   PY:
    #     name: Puducherry
    #   RJ:
    #     name: Rajasthan
    #   SK:
    #     name: Sikkim
    #   TG:
    #     name: Telangana
    #   TN:
    #     name: Tamil Nadu
    #   TR:
    #     name: Tripura
    #   UP:
    #     name: Uttar Pradesh
    #   UT:
    #     name: Uttarakhand
    #   WB:
    #     name: West Bengal

Then I'd appreciate looking at CONTRIBUTING.md and following the steps described to generate the initial fixtures files to allow passing the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants