Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSND-2942: Update pom dependencies #2

Merged
merged 5 commits into from
Aug 22, 2024
Merged

DSND-2942: Update pom dependencies #2

merged 5 commits into from
Aug 22, 2024

Conversation

cgregoryCH
Copy link
Contributor

@cgregoryCH cgregoryCH commented Aug 21, 2024 •
edited
Loading

Describe the changes

  • Updates pom dependencies to latest
  • Optimises imports
  • Jib plugin was not updated as the build was failing on the latest version
    See issue here

Related Jira tickets

DSND-2942

Developer check list

General

  • Is the PR as small as it can be?
  • Has the Jira ticket been updated with any relevant comments?
  • Is the README up to date?
  • Has the POM been updated for the latest versions of dependencies?
  • Has the code been double-checked against main?
  • Does the code adhere standards in this repository, including SonarQube checks?

Testing

  • Do the code changes have unit and integration tests with code coverage > 80%?
  • Has the code been tested locally and/or passed the API Karate tests on Tilt?
  • Have mandatory manual test cases been run?
  • Are extra Karate tests required?
  • Are all the test data resources up to date?

Release preparation

Where possible, add links to the respective Jira tickets when an item is checked

  • Have these changes been included in a release ticket?
  • Are changes required to the docker-chs-development deployment or test data?
  • Are any changes required to the environment added to deployment repositories?

Notes to the tester

Add any testing hints or instructions here.

@ch-code-analysis
Copy link

CI: No security warnings found

@cgregoryCH cgregoryCH merged commit d1af1ed into main Aug 22, 2024
1 check passed
@cgregoryCH cgregoryCH deleted the feature/dsnd-2942_code_style branch August 22, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthompsonCH sthompsonCH sthompsonCH approved these changes

@johncook-ch johncook-ch johncook-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgregoryCH @ch-code-analysis @sthompsonCH @johncook-ch