Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Text font option #168

Closed
wants to merge 10 commits into from
Closed

Text font option #168

wants to merge 10 commits into from

Conversation

ZacZhangzhuo
Copy link
Collaborator

@ZacZhangzhuo ZacZhangzhuo commented Oct 2, 2023

What type of change is this?

  • Text font option.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@tomvanmele tomvanmele requested a review from Licini October 3, 2023 15:36
@Licini
Copy link
Collaborator

Licini commented Oct 3, 2023

@ZacZhangzhuo Looks good to me, but the workflow indicates a Lint error, could you fix that:
https://github.com/compas-dev/compas_view2/actions/runs/6393924369/job/17358900922#step:2:4869

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants