Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Example files, fix #175 #180

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Example files, fix #175 #180

merged 7 commits into from
Oct 23, 2023

Conversation

ZacZhangzhuo
Copy link
Collaborator

@ZacZhangzhuo ZacZhangzhuo commented Oct 6, 2023

What type of change is this?

image

Request @Licini for a detailed review as this PR contains file naming and documentation operations.

  • Removing all the v120 prefixes of the files in the script folder.
  • Copying all the script files into example files, and making example pages.

Checklist

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I have added necessary documentation (if appropriate)

@Licini
Copy link
Collaborator

Licini commented Oct 6, 2023

Hey @ZacZhangzhuo These are great works! I'm now just nitpicking, I noticed some static images have a low resolution (or maybe compressed too much), for example this one for arrow docs\_images\example_arrows.jpg, could you replace them with better ones?

@ZacZhangzhuo
Copy link
Collaborator Author

Hey @ZacZhangzhuo These are great works! I'm now just nitpicking, I noticed some static images have a low resolution (or maybe compressed too much), for example this one for arrow docs\_images\example_arrows.jpg, could you replace them with better ones?

sure, :)

@Licini Licini merged commit 4404949 into compas-dev:main Oct 23, 2023
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants