Fix/grid obj #142
Closed
Fix/grid obj #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
reviewed
May 14, 2024
src/compas_viewer/ui/mainwindow.py
Outdated
Comment on lines
37
to
38
| self.grid: GridObject = self.viewer.scene.add(Frame.worldXY(), framesize=grid_size, show_frame=True, is_selected=False, is_locked=True, is_visible=True) | ||
| self.grid.init() |
There was a problem hiding this comment.
the grid is still added as an object in the scene. this should not be the case. the grid is part of the view itself...
There was a problem hiding this comment.
@tomvanmele do you mean sth like VIewer(show_grid=True)?
src/compas_viewer/ui/mainwindow.py
Outdated
Comment on lines
26
to
35
| def set_window_unit(self) -> None: | ||
| if self.viewer.config.window.unit == "m": | ||
| grid_size = (10000, 10, 10000, 10) | ||
| elif self.viewer.config.window.unit == "cm": | ||
| grid_size = (100, 10, 100, 10) | ||
| elif self.viewer.config.window.unit == "mm": | ||
| grid_size = (10, 10, 10, 10) | ||
| else: | ||
| print("Invalid unit") | ||
| return |
There was a problem hiding this comment.
i would prefer to deal wit units in a separate PR because it should be related to compas.tolerance
There was a problem hiding this comment.
okay I will just focus on resole gridobject here
PingHsunTsai
force-pushed
the
fix/grid_obj
branch
from
3e49608
to
f228048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#149 #150
GridObject restructure?
GridObjectinViewer()