Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obj info #170

Merged
merged 20 commits into from
Jun 18, 2024
Merged

obj info #170

merged 20 commits into from
Jun 18, 2024

Conversation

PingHsunTsai
Copy link
Collaborator

@PingHsunTsai PingHsunTsai commented May 28, 2024

What type of change is this?

  • Added object_info_cmd for compas_viewer.commends.

obj_setting_0

obj_setting_1

@PingHsunTsai PingHsunTsai self-assigned this May 28, 2024
@PingHsunTsai PingHsunTsai requested review from tomvanmele and Licini and removed request for tomvanmele May 28, 2024 12:41
@Licini
Copy link
Collaborator

Licini commented Jun 7, 2024

@tomvanmele Didn't we want to show these kind of information at the lower half of right side bar? Or is this a feature that you requested?

@PingHsunTsai
Copy link
Collaborator Author

I think the idea is have them at both :) I will implement it in the sidebar as well

@tomvanmele
Copy link
Member

i would like to have this in the default bottom slot of the sidebar on the right indeed. doesn't hurt to have it as a popup as well. either way, i would like to see this information a bit more organised though. for example in a table. and it should be modifiable...

@PingHsunTsai PingHsunTsai marked this pull request as draft June 11, 2024 16:08
@PingHsunTsai PingHsunTsai marked this pull request as ready for review June 14, 2024 07:44
@PingHsunTsai
Copy link
Collaborator Author

PingHsunTsai commented Jun 14, 2024

now the object setting is both in sidebar and menu, will update them to config once #169 is finished! let me know if there are missing attr to add to the obj setting

@tomvanmele tomvanmele merged commit 12990c8 into main Jun 18, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants