fix tabobject #184
Merged
fix tabobject #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
reviewed
Jun 25, 2024
CHANGELOG.md
Outdated
| @@ -39,7 +39,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Restructured `SceneObjects` to accepct `item` as kwargs. | |||
| * Fixed `compas_viewer.components.slider` step attribute. | |||
| * Fixed `renderer.view` distorted init | |||
|
|
|||
| * Fixed in a `tabobject` | |||
There was a problem hiding this comment.
and put a period at the end of every sentence
src/compas_viewer/scene/tagobject.py
Outdated
| @@ -118,6 +118,7 @@ def make_buffers(self): | |||
| } | |||
|
|
|||
| def make_text_texture(self): | |||
| print(self.geometry.font) | |||
There was a problem hiding this comment.
Ahh no there was a missing file, I will remove this print line
tomvanmele
reviewed
Jun 25, 2024
CHANGELOG.md
Outdated
| @@ -38,7 +38,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Changed `FrameObject` to something with just 3 axes. | |||
| * Restructured `SceneObjects` to accepct `item` as kwargs. | |||
| * Fixed `compas_viewer.components.slider` step attribute. | |||
| * Fixed `renderer.view` distorted init | |||
| * Fixed `renderer.view` distorted init. | |||
| * Fixed in a `tabobject`. | |||
There was a problem hiding this comment.
sry didn't see the typo
PingHsunTsai
commented
Jun 25, 2024
There was a problem hiding this comment.
By putting back the missing file here, tagobject file can be fixed
tomvanmele
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change is this?
tabobject