Bump v304

[carlodri]

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[carlodri]

@conda-forge-admin please rerender

[carlodri]

😤not sure about what is going on here, some googling around shows that there might be Visual Studio version conflicts... (see here?)

[carlodri]

@nicoddemus any idea?

[nicoddemus]

Hmm not immediately at a glance, I'm afraid. 😕

Perhaps @tadeu can give some insight?

[carlodri]

@conda-forge-admin please rerender

[carlodri]

Seems like the problem is different now after re-rendering:

2022-08-28T20:08:30.7497049Z AutoComplete.cxx
2022-08-28T20:08:30.7923453Z ..\src\AutoComplete.cxx(8): fatal error C1083: Cannot open include file: 'stdlib.h': No such file or directory
2022-08-28T20:08:30.8873165Z NMAKE :  U1077: '"C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.29.30133\bin\HostX64\x64\cl.EXE"' : return code '0x2'
2022-08-28T20:08:30.8875493Z Stop.
2022-08-28T20:08:30.8982002Z Skipping axdebug: AXDebug no longer builds on 3.11 and up
2022-08-28T20:08:30.8983400Z Skipping exchdapi: No 64-bit library for utility functions available.
2022-08-28T20:08:30.8984202Z error: can't copy 'build\temp.win-amd64-cpython-310\Release\scintilla\scintilla.dll': doesn't exist or not a regular file

[tadeu]

From StackOverflow:

In my opinion, the reason is: stdio.h these header files are not located in the path is not in the default path of VS2017, resulting in VS2017 can not find these header files.

I suggest that you could add the following paths in Properties.

VC++ Directories->Include Directories: C:\Program Files (x86)\Windows Kits\10\Lib\10.0.17134.0\ucrt

VC++ Directories->Library Directories: C:\Program Files (x86)\Windows Kits\10\Lib\10.0.17134.0\ucrt\x86

I'm not sure how it worked before, but it looks like it needs changes to environment variables (or a patch) to add some include directories (adapted to the current VS and SDK versions, if possible using environment variables such as UniversalCRTSdkDir or VCToolsInstallDir to be more generic and future-proof).

Another option would be to, if possible, try to customize the build to drop the Scintilla part, I'm not sure if that part is necessary to the package. The root of the problem seems to be a C++ file including headers from C: https://github.com/mhammond/pywin32/blob/main/Pythonwin/Scintilla/src/AutoComplete.cxx#L8. If the problem is localized in this file only, it could be patched to include <cstdlib> instead of stdlib.h (the same for other C headers).

[carlodri]

thanks for you hints @tadeu! Hope I can find some time soon to look into them and try fixing this.

[carlodri]

@tadeu I see in the logs that the ucrt package is being installed, is this correct? I'm asking since it appears that it should be installed only for Windows < 10 (see here).

[carlodri]

@conda-forge-admin please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pywin32-feedstock/actions/runs/3035160515.

[carlodri]

Sorry to drag you in this @isuruf, but having seen conda-forge/vc-feedstock#38 I was wondering if this could be somehow related. Do you have any insight? Before hand-crafting patches I wanted to ensure that the problem is not upstream in the toolchain.

[carlodri]

@conda-forge-admin please rerender

[tadeu]

It does seem related to ucrt and vc, if ucrt is being installed in the build env, perhaps, for a workaround, it's a matter of finding out where is this missing header, and adding it "manually" as an include dir.

[carlodri]

hmm, works by disabling scintilla. Not sure now disabling this component would affect users....

@conda-forge/pywin32 what is your call on this?

[carlodri]

@conda-forge-admin please rerender

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

• Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [20]

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[carlodri]

the correct folder C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt is already in %INCLUDE%.... looks like compiler is ignoring it?

[carlodri]

@conda-forge-admin please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pywin32-feedstock/actions/runs/3179863788.

[carlodri]

@conda-forge-admin please rerender

[github-actions]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/pywin32-feedstock/actions/runs/3200030735.

[carlodri]

cleaning up the mess and reverting back to the working version without scintilla

will wait for comments for some days and then merge...

[isuruf]

This is probably pypa/distutils#174

[carlodri]

@conda-forge-admin please rerender

[nicoddemus]

Thanks!