[qt5] icu 75 rebuild with additional patches and remove use of cdts #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
Tobias-Fischer,
andfoy,
ccordoba12,
gillins,
jschueller,
matthiasdiener,
mingwandroid,
msarahan,
ocefpaf and
stuarteberg
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
New error on Windows after ~3.5 hours: |
This requires a manual modification that is overwritten by rendering, see #269 (comment) . |
|
I was hoping the atl situation would be resolved by the images themselves, but given that this isn't happening, I think we'll have to teach smithy to add these workarounds |
1 task
I opened conda-forge/conda-smithy#2062 to track this. |
|
Ok, Windows build is happy. Obviously all the other builds now started to fail, @hmaarrfk in #282 (comment) you mentioned that this problem may be resolved, was this because you had any pointer/hint on this? Thanks! Instead, linux-64 is failing with |
|
@conda-forge-admin please rerender |
|
i probably meant that "work could be done to resolve it" not that I had solved it. I might try to download a newer version and do a diff on the file. |
Yes, I imagined, but it was worth asking just in case. I will look into that, thanks! |
On a related note, this is the same command in the last successful build: and the same command now: The commands invoked is exactly the same. In the working version we had |
|
@conda-forge-admin please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/qt-main-feedstock/actions/runs/10871165405. |
hmaarrfk
reviewed
Sep 15, 2024
| " ucol_close(collator);" | ||
| - ] | ||
| + ], | ||
| + "qmake": "CONFIG += c++17" |
There was a problem hiding this comment.
such a good patch! great job!
|
Not sure if you knew about this repo (i didn't) https://github.com/qt/qt5 |
|
It might be this "commit" that fixes things... but it seems old and already be included in the 5.15 branch? qt/qtbase@1b488d8#diff-25c4cd4ef98b78f1b822c473dbbb29beb03092d0629b2c82982260ade1aa8521 |
|
(i'll be a little more patient in building the aarch64 + ppc64le builds) |
|
Ok, final boss, just a failure on that is easy, probably |
1 task
|
CI seems happy. @hmaarrfk do you have some preference on cleaning up a bit commits or it is ok like this (a bit messy)? |
|
you can rebase if you want, will help in 2 years to read your great work! I also want to see if this #289 works. Trying your patch now. |
|
well the patch needs a bit of work, it will have to wait till tonight. thanks for your hard work. I'll start compiling aarch _ ppc64 tonight as well regardless of the ptach |
Ok! Just to understand, do you want to work on this yourself or are you asking me to do a bit of work (in that case I am not sure which work are you asking for). |
Then maybe copy over the "no CDT changes" if you think they are appropriate as a single commit. If you can start the AARCH+PCC64le builds that would be great under CFEP03 (as in keep the logs too). |
traversaro
changed the title
traversaro
changed the title
|
@conda-forge-admin please rerender |
…nda-forge-pinning 2024.09.17.12.57.55
Done, I will try to start CFEP03 builds now. |
cfep builds completed:
|
Merged
5 tasks
anaconda seems down.... |
|
back up online! thanks @traversaro |
|
Amazing work! 🥳 |
|
Thanks to everyone that contributed! |
|
Thanks for the effort! Much appreciated.
…On Wed, Sep 18, 2024 at 8:02 AM Silvio Traversaro ***@***.***> wrote:
Thanks to everyone that contributed!
—
Reply to this email directly, view it on GitHub
<#288 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4WHGJDLZWF4HNI76RQVXTZXF2YDAVCNFSM6AAAAABOFX2M5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJYGQYTEMZZGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)