Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated v2.2.0 #4

Merged
merged 5 commits into from
Mar 2, 2020
Merged

updated v2.2.0 #4

merged 5 commits into from
Mar 2, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Mar 2, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@seanyen seanyen marked this pull request as ready for review March 2, 2020 10:12
@seanyen
Copy link
Contributor Author

seanyen commented Mar 2, 2020

@conda-forge/urdfdom This is ready for review and merge. Thanks!

@wolfv
Copy link
Member

wolfv commented Mar 2, 2020

cool stuff!

@wolfv wolfv merged commit a7470e5 into conda-forge:master Mar 2, 2020
@traversaro
Copy link
Contributor

Hi @seanyen , not that unfortunately the ros2 version used here does not contain all the features present in the "official" ros/urdfdom version, see ros/urdfdom_headers#59 (comment) .

@seanyen
Copy link
Contributor Author

seanyen commented Mar 2, 2020

Hi @seanyen , not that unfortunately the ros2 version used here does not contain all the features present in the "official" ros/urdfdom version, see ros/urdfdom_headers#59 (comment) .

Thanks for letting me know! You are really ahead on this front. :)

@traversaro
Copy link
Contributor

traversaro commented Mar 3, 2020

Hi @seanyen , not that unfortunately the ros2 version used here does not contain all the features present in the "official" ros/urdfdom version, see ros/urdfdom_headers#59 (comment) .

Thanks for letting me know! You are really ahead on this front. :)

Just because I had to debug a nasty bug related to this (robotology-legacy/gym-ignition#118 (comment)). : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants