Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/improve support for Path dependencies and GIT dependencies #712

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

romain-intel
Copy link
Contributor

Specifically:

  • adds subdirectory for GIT dependencies
  • adds the ability to pass "path" dependencies to Poetry

Description

This simply extends support of the arguments that conda-lock can parse in a pyproject.toml and passes them down to Poetry. Specifically it adds support for local directories and wheels as well as support for #subdirectory in GIT packages.

Specifically:
  - adds subdirectory for GIT dependencies
  - adds the ability to pass "path" dependencies to Poetry
@romain-intel romain-intel requested a review from a team as a code owner September 27, 2024 05:49
Copy link

netlify bot commented Sep 27, 2024

Deploy Preview for conda-lock ready!

Name Link
🔨 Latest commit 247d1cb
🔍 Latest deploy log https://app.netlify.com/sites/conda-lock/deploys/66f64e6b1a0f7f0008cb6fd7
😎 Deploy Preview https://deploy-preview-712--conda-lock.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@romain-intel
Copy link
Contributor Author

Need to add a test for subdirectory.

@romain-intel
Copy link
Contributor Author

I suspect the micromamba test failures may be due to the release of micromamba 2.0

@maresb
Copy link
Contributor

maresb commented Sep 28, 2024

I suspect the micromamba test failures may be due to the release of micromamba 2.0

Noooooo! 😱 I wanted to release! Ok, I guess we have more work.

Regarding this PR, it looks mostly great. One of my big concerns is favoring Poetry-style pyproject.toml over standards-based pyproject.toml. I think/hope that this would be a really simple tweak to achieve this. I think you basically just need to support

parse_python_requirement("/path/to/some-package", manager="pip", mapping_url=DEFAULT_MAPPING_URL)

Looking forward to the additional test for subdir. Thanks again @romain-intel!!!

@maresb
Copy link
Contributor

maresb commented Sep 28, 2024

Ok, micromamba v2 was not so bad. I believe I took care of it in #713. Feel free to rebase on main, and I hope that will fix things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants