-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add edge case tests for StringMatcher
#839
Merged
baszalmstra
merged 1 commit into
conda:main
from
kelvinou01:improvement/match-spec-tests
Aug 30, 2024
Merged
feat: add edge case tests for StringMatcher
#839
baszalmstra
merged 1 commit into
conda:main
from
kelvinou01:improvement/match-spec-tests
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinou01
changed the title
feat: add edge case tests for MatchSpec
feat: add edge case tests for Aug 30, 2024
StringMatcher
baszalmstra
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Merged
baszalmstra
added a commit
that referenced
this pull request
Sep 2, 2024
## 🤖 New release * `rattler_conda_types`: 0.27.2 -> 0.27.3 * `rattler_package_streaming`: 0.22.3 -> 0.22.4 * `rattler_lock`: 0.22.20 -> 0.22.21 * `rattler_solve`: 1.0.3 -> 1.0.4 * `rattler_virtual_packages`: 1.0.4 -> 1.1.0 * `rattler_index`: 0.19.24 -> 0.19.25 * `rattler`: 0.27.6 -> 0.27.7 * `rattler_cache`: 0.1.8 -> 0.1.9 * `rattler_shell`: 0.21.6 -> 0.21.7 * `rattler_repodata_gateway`: 0.21.8 -> 0.21.9 <details><summary><i><b>Changelog</b></i></summary><p> ## `rattler_conda_types` <blockquote> ## [0.27.3](rattler_conda_types-v0.27.2...rattler_conda_types-v0.27.3) - 2024-09-02 ### Added - add edge case tests for `StringMatcher` ([#839](#839)) </blockquote> ## `rattler_package_streaming` <blockquote> ## [0.22.4](rattler_package_streaming-v0.22.3...rattler_package_streaming-v0.22.4) - 2024-09-02 ### Added - Add support for `CONDA_OVERRIDE_CUDA` ([#818](#818)) ### Fixed - zip large files compression ([#838](#838)) </blockquote> ## `rattler_lock` <blockquote> ## [0.22.21](rattler_lock-v0.22.20...rattler_lock-v0.22.21) - 2024-09-02 ### Added - Add support for `CONDA_OVERRIDE_CUDA` ([#818](#818)) </blockquote> ## `rattler_solve` <blockquote> ## [1.0.4](rattler_solve-v1.0.3...rattler_solve-v1.0.4) - 2024-09-02 ### Fixed - Redact spec channel before comparing it with repodata channel ([#831](#831)) ### Other - Remove note that only libsolv is supported ([#832](#832)) </blockquote> ## `rattler_virtual_packages` <blockquote> ## [1.1.0](rattler_virtual_packages-v1.0.4...rattler_virtual_packages-v1.1.0) - 2024-09-02 ### Added - start adding interface to override ([#834](#834)) - Add support for `CONDA_OVERRIDE_CUDA` ([#818](#818)) ### Other - make virtual package overrides none by default consistently ([#842](#842)) </blockquote> ## `rattler_index` <blockquote> ## [0.19.25](rattler_index-v0.19.24...rattler_index-v0.19.25) - 2024-09-02 ### Other - release ([#824](#824)) </blockquote> ## `rattler` <blockquote> ## [0.27.7](rattler-v0.27.6...rattler-v0.27.7) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types, rattler_package_streaming </blockquote> ## `rattler_cache` <blockquote> ## [0.1.9](rattler_cache-v0.1.8...rattler_cache-v0.1.9) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types, rattler_package_streaming </blockquote> ## `rattler_shell` <blockquote> ## [0.21.7](rattler_shell-v0.21.6...rattler_shell-v0.21.7) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_repodata_gateway` <blockquote> ## [0.21.9](rattler_repodata_gateway-v0.21.8...rattler_repodata_gateway-v0.21.9) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
kelvinou01
pushed a commit
to kelvinou01/rattler
that referenced
this pull request
Sep 3, 2024
## 🤖 New release * `rattler_conda_types`: 0.27.2 -> 0.27.3 * `rattler_package_streaming`: 0.22.3 -> 0.22.4 * `rattler_lock`: 0.22.20 -> 0.22.21 * `rattler_solve`: 1.0.3 -> 1.0.4 * `rattler_virtual_packages`: 1.0.4 -> 1.1.0 * `rattler_index`: 0.19.24 -> 0.19.25 * `rattler`: 0.27.6 -> 0.27.7 * `rattler_cache`: 0.1.8 -> 0.1.9 * `rattler_shell`: 0.21.6 -> 0.21.7 * `rattler_repodata_gateway`: 0.21.8 -> 0.21.9 <details><summary><i><b>Changelog</b></i></summary><p> ## `rattler_conda_types` <blockquote> ## [0.27.3](conda/rattler@rattler_conda_types-v0.27.2...rattler_conda_types-v0.27.3) - 2024-09-02 ### Added - add edge case tests for `StringMatcher` ([conda#839](conda#839)) </blockquote> ## `rattler_package_streaming` <blockquote> ## [0.22.4](conda/rattler@rattler_package_streaming-v0.22.3...rattler_package_streaming-v0.22.4) - 2024-09-02 ### Added - Add support for `CONDA_OVERRIDE_CUDA` ([conda#818](conda#818)) ### Fixed - zip large files compression ([conda#838](conda#838)) </blockquote> ## `rattler_lock` <blockquote> ## [0.22.21](conda/rattler@rattler_lock-v0.22.20...rattler_lock-v0.22.21) - 2024-09-02 ### Added - Add support for `CONDA_OVERRIDE_CUDA` ([conda#818](conda#818)) </blockquote> ## `rattler_solve` <blockquote> ## [1.0.4](conda/rattler@rattler_solve-v1.0.3...rattler_solve-v1.0.4) - 2024-09-02 ### Fixed - Redact spec channel before comparing it with repodata channel ([conda#831](conda#831)) ### Other - Remove note that only libsolv is supported ([conda#832](conda#832)) </blockquote> ## `rattler_virtual_packages` <blockquote> ## [1.1.0](conda/rattler@rattler_virtual_packages-v1.0.4...rattler_virtual_packages-v1.1.0) - 2024-09-02 ### Added - start adding interface to override ([conda#834](conda#834)) - Add support for `CONDA_OVERRIDE_CUDA` ([conda#818](conda#818)) ### Other - make virtual package overrides none by default consistently ([conda#842](conda#842)) </blockquote> ## `rattler_index` <blockquote> ## [0.19.25](conda/rattler@rattler_index-v0.19.24...rattler_index-v0.19.25) - 2024-09-02 ### Other - release ([conda#824](conda#824)) </blockquote> ## `rattler` <blockquote> ## [0.27.7](conda/rattler@rattler-v0.27.6...rattler-v0.27.7) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types, rattler_package_streaming </blockquote> ## `rattler_cache` <blockquote> ## [0.1.9](conda/rattler@rattler_cache-v0.1.8...rattler_cache-v0.1.9) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types, rattler_package_streaming </blockquote> ## `rattler_shell` <blockquote> ## [0.21.7](conda/rattler@rattler_shell-v0.21.6...rattler_shell-v0.21.7) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_repodata_gateway` <blockquote> ## [0.21.9](conda/rattler@rattler_repodata_gateway-v0.21.8...rattler_repodata_gateway-v0.21.9) - 2024-09-02 ### Other - updated the following local packages: rattler_conda_types </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StringMatcher
(not exactly Test: Check invalidation of matchspecs that are formatted incorrect #205, but related)