chore: apply clippy's suggetions

[SobhanMP]

I think it's sometimes helpful to use Clippy to avoid common mistakes. Unfortunately, this repo generates way too many of these.

The only one I could not figure out was

#[allow(clippy::ptr_arg)]
fn get_bytes_offset(lines: &Vec<&str>)

This commit is not supposed to change any behavior whatsoever.

[baszalmstra]

Thats strange since we run clippy in CI! Would you be able to figure out why these werent caught and adapt the workflow so we catch these things earlier in the future?

[SobhanMP]

I think that precommit only runs clippy on changed files

[SobhanMP]

but then precommit doesn't run clippy

rattler/.github/workflows/pre-commit.yaml

Line 21 in 8a9fed3

SKIP: clippy,fmt

[baszalmstra]

We run clippy here:

rattler/.github/workflows/rust-compile.yml

Line 53 in 8a9fed3

- name: Run clippy

[SobhanMP]

yeah, that's what i realized

[SobhanMP]

i think we need to run it with cargo clippy -- -D warnings so that the job fails on warnings

[baszalmstra]

We are because of:

rattler/.github/workflows/rust-compile.yml

Line 23 in 8a9fed3

RUSTFLAGS: "-D warnings"

[baszalmstra]

Which version of rust are you using?

We are still using 1.75.0 which is pinned through the rust-toolchain file. Are you perhaps using a higher version?

[SobhanMP]

rustc --version
rustc 1.80.1 (3f5fd8dd4 2024-08-06)

Ah

[baszalmstra]

I assume you are not using pixi or rustup? How did you install the rust compiler?

[SobhanMP]

rustup?

[SobhanMP]

ps. https://releases.rs/ show that 1.80 is stable

[SobhanMP]

maybe it's a good idea to bump https://github.com/conda/rattler/blob/c02c9926318867fc61f25cb247588ae24263f9cb/rust-toolchain? or not setting it so it always stays at stable

[baszalmstra]

maybe it's a good idea to bump c02c992/rust-toolchain? or not setting it so it always stays at stable

We want to pin the rust compiler version because otherwise every time a new version comes out we have a lot of clippy warnings (exactly what you ran into). Bumping it is a good idea, this is already happening in #837

[baszalmstra]

#837 has been merged which bumps the rust toolchain to 1.80.0. This introduces a number of conflicts. Can you check if there are still missing clippy warnings?

[SobhanMP]

Yep, every thing looks good!