test/e2e/livirt: allow prop file overwrite cluster name #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bookinabox thanks! There is at least one fix though. When I ran on my machine it created correctly the "peer-pods-e2e" cluster but then later tried to connect to "peer-pods" (see the logs below). You will need to change this line: https://github.com/confidential-containers/cloud-api-adaptor/blob/main/libvirt/kcli_cluster.sh#L55 |
bookinabox
force-pushed
the
libvirt-e2e-test-cluster-name-overwrite
branch
from
bb614e0
to
9156272
Compare
|
@bookinabox could you please resolve the conflict and resubmit? |
Creates a cluster_name property that can be added to the libvirt properties file and corresponding LibvirtProvisioner struct. Before createCluster executes kcli_cluster.sh, it adds the cluster name, network, and storage pool to the environment. Fixes: confidential-containers#1163 Signed-off-by: Derek Lee <derlee@redhat.com>
bookinabox
force-pushed
the
libvirt-e2e-test-cluster-name-overwrite
branch
from
9156272
to
959be76
Compare
wainersm
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Hi @bookinabox , I just tested this PR and it looks good. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a cluster_name property that can be added to the libvirt properties file and corresponding LibvirtProvisioner struct.
Before createCluster executes kcli_cluster.sh, it adds the cluster name, network, and storage pool to the environment.
Fixes: #1163