test: misc enhancements to the azure e2e test code #1394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've thrown those in a single PR, mostly because it's friday. We can untangle, if desired, ofc.
Remove option to pass secrets to test run
since leakage of secrets in the CI is a risk and federated credentials work well on github actions we remove the option to pass a CLIENT_SECRET to a test run. Local runs can keep using cli auth.
Parallize the tests
it will speed up a test run and is a valid test path. there are no dependencies between the test cases, so flakes due to this would imply a bug we want to be aware of.
Later, when we add more tests, we probably want to increase the parallelism when invoking go test, since it'll use nproc by default but the tests are not cpu-bound.
There is a misnomer in the ssh key parameter.
There is no need to query the API for the rg name in the cloud asserter, since we have the name in all cases.
Successful test run here