-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libvirt install latest update and post-release update part II #2004
Libvirt install latest update and post-release update part II #2004
Conversation
1395763
to
391e60a
Compare
docs/Release-Process.md
Outdated
``` | ||
./hack/release-helper.sh caa-image-tag latest | ||
``` | ||
The commit that pinned the overlay kustomization files should be reverted to start using the latest cloud-api-adaptor images again: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, s/:/.
- Update the CITATION.cff for the 0.9.0 release Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Rather than running ./hack/release-helper.sh caa-image-tag it's easier to just revert the commit that pinned the CAA versions in the first place, so we don't have to worry about dev-latest vs latest logic Signed-off-by: stevenhorsman <steven@uk.ibm.com>
This reverts commit 5e706f6. Signed-off-by: stevenhorsman <steven@uk.ibm.com>
This reverts commit 65ee857. Signed-off-by: stevenhorsman <steven@uk.ibm.com>
391e60a
to
18279b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stevenhorsman !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
For reasons I don't fully understand, our
latest
image manifest includes the dev version(s) of CAA, so we don't produce adev-latest
, so update the release process to revert the pinning commit instead of trying to be clever.Also update the CITATION which was missed.