Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libvirt install latest update and post-release update part II #2004

Conversation

stevenhorsman
Copy link
Member

For reasons I don't fully understand, our latest image manifest includes the dev version(s) of CAA, so we don't produce a dev-latest, so update the release process to revert the pinning commit instead of trying to be clever.
Also update the CITATION which was missed.

@stevenhorsman stevenhorsman added test_e2e_libvirt Run Libvirt e2e tests provider/libvirt release Issues related with release process, including its documentation and removed test_e2e_libvirt Run Libvirt e2e tests labels Aug 14, 2024
```
./hack/release-helper.sh caa-image-tag latest
```
The commit that pinned the overlay kustomization files should be reverted to start using the latest cloud-api-adaptor images again:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, s/:/.

- Update the CITATION.cff for the 0.9.0 release

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Rather than running ./hack/release-helper.sh caa-image-tag
it's easier to just revert the commit that pinned the CAA versions
in the first place, so we don't have to worry about dev-latest vs latest logic

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
This reverts commit 5e706f6.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
This reverts commit 65ee857.

Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Copy link
Member

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevenhorsman !

Copy link
Member

@beraldoleal beraldoleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@wainersm wainersm merged commit 7f07f9a into confidential-containers:main Sep 16, 2024
19 checks passed
@stevenhorsman stevenhorsman deleted the libvirt-install-latest-update branch September 16, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/libvirt release Issues related with release process, including its documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants