test/e2e: kbs: Use the cached kbs-client #2121
Merged
+16
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenhorsman
force-pushed
the
kbs-client-cache
branch
from
c4bbb1a
to
9ef2439
Compare
stevenhorsman
force-pushed
the
kbs-client-cache
branch
7 times, most recently
from
ad1901b
to
ef2e562
Compare
To save us storage space, time and the requirement on the rust toolchain, we can pull down the cached kbs-client rather than building it ourselves. - Update checkout_kbs.sh to use oras to pull the kbs-client binary from the cache rather than building it. - Fix the kbs-client path now that it is pulled into `kbs`, not build into target/releases Signed-off-by: stevenhorsman <steven@uk.ibm.com>
- Remove the rust toolchain install from the workflow now it's no longer needed. > [!NOTE] > We need a follow up PR to remove rust from versions.yaml > separately due to the pull_request_target issues - Remove unused envs Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
force-pushed
the
kbs-client-cache
branch
from
ef2e562
to
3abad2e
Compare
mkulke
approved these changes
Oct 22, 2024
bpradipt
approved these changes
Oct 22, 2024
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 22, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 23, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 23, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 24, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 25, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 25, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 29, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
stevenhorsman
added a commit
to stevenhorsman/cloud-api-adaptor
that referenced
this pull request
Oct 29, 2024
After confidential-containers#2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
wainersm
pushed a commit
that referenced
this pull request
Oct 29, 2024
After #2121 the rust version is no longer needed Signed-off-by: stevenhorsman <steven@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To save us storage space, time and the requirement
on the rust toolchain, we can pull down the cached
kbs-client rather than building it ourselves.
Update checkout_kbs.sh to use oras to pull the kbs-client
binary from the cache rather than building it.