Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable concurrency for child workflows #2133

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Oct 28, 2024

Those should not be set for callable workflows, since it's not supported to have concurrency groups set on both parent and children workflows.

github/vscode-github-actions#135

Those should not be set for callable workflows, since it's not supported
to have concurrency groups set on both parent and children workflows.

github/vscode-github-actions#135

Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
@mkulke mkulke requested a review from a team as a code owner October 28, 2024 09:57
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for my lack of knowledge that let this in!

@wainersm
Copy link
Member

LGTM. Sorry for my lack of knowledge that let this in!

And I tested that latest https://github.com/rhysd/actionlint/ wouldn't have caught it either.

@wainersm wainersm merged commit ab5d717 into confidential-containers:main Oct 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants