Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Symfony 7 #110

Closed
wants to merge 2 commits into from
Closed

Support Symfony 7 #110

wants to merge 2 commits into from

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Apr 1, 2024

@fjgarlin
Copy link
Contributor

fjgarlin commented Apr 2, 2024

I saw what you did in this PR @weitzman and tried to replicate it here #111 to see if I could fix those errors. They are all green now, but I don't understand how this tests Symfony 7 if we are committing the composer.lock file.

@weitzman
Copy link
Member Author

weitzman commented Apr 2, 2024

Thanks. See the 'highest' matrix runs in this PR. The step is called 'install highest'. It ignores the lockfile.

Closing in favor of your PR.

@weitzman weitzman closed this Apr 2, 2024
@fjgarlin
Copy link
Contributor

fjgarlin commented Apr 2, 2024

Oh great! Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weitzman @fjgarlin