-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RamaLama container image build #446
Conversation
Error: (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) Problem: conflicting requests - nothing provides libLLVM-17.so()(64bit) needed by mesa-vulkan-drivers-23.3.3-102.el9.x86_64 from copr:copr.fedorainfracloud.org:slp:mesa-krunkit - nothing provides libLLVM-17.so(LLVM_17)(64bit) needed by mesa-vulkan-drivers-23.3.3-102.el9.x86_64 from copr:copr.fedorainfracloud.org:slp:mesa-krunkit Error: building at STEP "RUN chmod +x /scripts/*.sh && /scripts/build_llama_and_whisper.sh "ramalama" "$LLAMA_CPP_SHA" "$WHISPER_CPP_SHA" "/usr" "-DGGML_KOMPUTE=1"": while running runtime: exit status 1 make: *** [Makefile:78: build] Error 1 Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Reviewer's Guide by SourceryThis PR fixes the RamaLama container image build by reordering package installation dependencies. The core issue was related to package dependency resolution where mesa-vulkan-drivers required LLVM-17 libraries that weren't available at the time of installation. Sequence diagram for the package installation processsequenceDiagram
participant Script
participant DNF
participant COPR
participant CentOSMirror
participant RPM
Script->>DNF: Enable COPR repo slp/mesa-krunkit
DNF->>COPR: Request repo access
COPR-->>DNF: Repo enabled
Script->>DNF: Add CentOS Stream repo
DNF->>CentOSMirror: Request repo access
CentOSMirror-->>DNF: Repo added
Script->>RPM: Import CentOS GPG key
RPM-->>Script: Key imported
Script->>DNF: Install packages
DNF->>COPR: Resolve dependencies
DNF->>CentOSMirror: Resolve dependencies
DNF-->>Script: Packages installed successfully
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider explicitly installing LLVM 17 package to resolve the missing libLLVM-17.so dependency, rather than relying on package ordering.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LGTM |
Error:
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)
Problem: conflicting requests
Error: building at STEP "RUN chmod +x /scripts/*.sh && /scripts/build_llama_and_whisper.sh "ramalama" "$LLAMA_CPP_SHA" "$WHISPER_CPP_SHA" "/usr" "-DGGML_KOMPUTE=1"": while running runtime: exit status 1
make: *** [Makefile:78: build] Error 1
Summary by Sourcery
Bug Fixes: