Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes 2617: copy/download repo config from snapshot list #170

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fixes 2617: copy/download repo config from snapshot list #170

merged 1 commit into from
Nov 14, 2023

Conversation

rverdile
Copy link
Contributor

@rverdile rverdile commented Nov 9, 2023 •
edited
Loading

Summary

Adds a new column to the snapshot list modal that allows the user to either copy or download the repo config file for the snapshot.

Testing steps

  1. Create a repository with snapshotting enabled
  2. Click "view all snapshots" on the kebab
  3. Under the "Config" tab, try clicking the copy icon (to copy) and the download icon (to download)

@rverdile rverdile force-pushed the repo-config-download branch from f86fd47 to 63443d5 Compare November 10, 2023 18:14
@rverdile rverdile changed the title copy/download repo config Fixes 2617: copy/download repo config from snapshot list Nov 10, 2023
@rverdile rverdile marked this pull request as ready for review November 10, 2023 18:24
@jlsherrill
Copy link
Member

https://issues.redhat.com/browse/HMS-2617

Andrewgdewar
Andrewgdewar approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Andrewgdewar Andrewgdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack!

@rverdile @Andrewgdewar
Fixes 2617: copy/download repo config from snapshot list
8c1c39e 
Co-authored-by: Andrew Dewar <andrewgdewar@gmail.com>
@rverdile rverdile force-pushed the repo-config-download branch from 63443d5 to 8c1c39e Compare November 13, 2023 15:35
@swadeley
Copy link
Member

swadeley commented Nov 14, 2023 •
edited
Loading

Hi

testing copy icon (by pasting the output here):

[test1]
name=test1
baseurl=https://env-ephemeral-dax0gk.<xxx>.openshiftapps.com/pulp/content/a95cf632/3cff7cc2-5fb1-4a8d-9e12-869f5d94ffc6/b297423d-a638-44a9-81e7-2fd7fea89f6e/
gpgcheck=0
repo_gpgcheck=0
enabled=1

Testing download icon:


Downloads]$ cat config.repo 
[test1]
name=test1
baseurl=https://env-ephemeral-dax0gk.<xxx>.openshiftapps.com/pulp/content/a95cf632/3cff7cc2-5fb1-4a8d-9e12-869f5d94ffc6/b297423d-a638-44a9-81e7-2fd7fea89f6e/
gpgcheck=0
repo_gpgcheck=0
enabled=1

Nice, thank you

@swadeley swadeley merged commit 237de57 into content-services:main Nov 14, 2023
5 of 6 checks passed
@swadeley
Copy link
Member

swadeley commented Nov 14, 2023 •
edited
Loading

Example of the download and copy icons:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrewgdewar Andrewgdewar Andrewgdewar approved these changes

Assignees
No one assigned
Labels
qe-testing-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rverdile @jlsherrill @swadeley @Andrewgdewar