-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 4743: add delete and bulk delete of snapshots #373
Conversation
Hi @dominikvagner, please rebase |
/retest |
.../ContentListTable/components/SnapshotListModal/DeleteSnapshotsModal/DeleteSnapshotsModal.tsx
Outdated
Show resolved
Hide resolved
...s/Repositories/ContentListTable/components/SnapshotListModal/components/LatestRepoConfig.tsx
Outdated
Show resolved
Hide resolved
this should likely be moved to inclose the FlexItem to prevent the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, pending the conclusion of the above comments.
fixed! 🫡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/retest |
testing these changes after merging the PR |
Summary
This PR adds the UI changes needed for manual snapshot deletion. In the snapshot list modal a checkbox and a kebab menu has been added for each snapshot which can be used to bulk delete or single delete the chosen snapshots.
New "delete snapshots confirmation" modal has been added where the to be deleted snapshots are displayed together with any templates that use those snapshots, so that the users are warned this change will also affect those templates. A separate warning alert is displayed in that case.
Related ticket: [HMS-4743]
Testing steps
Workflow checks:
use_latest
and the other has a date in the past.General checks:
repoWrite
permissions.