Add an option to disable the "recheck" part of the comment

[kingthorin]

We've found that due to the suggestion in the action's comment that users' comment "recheck" we've ended up with everyone commenting their agreement immediately followed by commenting recheck. Or, commenting both in the same comment. Therefore we'd like the option to disable the "recheck" suggestion.

Note: I have very little experience with GitHub action creation/contribution, if I've edited something I shouldn't have then please let me know, or conversely missed editing something I should have.

Prepared via: dev.github.com
Modeled mainly based on lock-pullrequest-aftermerge handling.

[kingthorin]

Hmmm I have no idea why so much of dist/index.js is showing changes. Perhaps dev.github.com adjusted line endings?

[kingthorin]

That seems to be what it is. If I choose “Hide white space” when viewing the diff then it appears as expected. I’ll look at pulling it into a real editor and fixing it.

[kingthorin]

I don't seem to be able to revert whatever those white space changes were. The only changes I actually implemented were on line < 1100

When viewing the diff if you select hide white space or hide white space changes then it'll be focused on intended changes.

[kingthorin]

Screenshot of diff ignoring whitespace _{(Click the triangle/control to expand)}

[kingthorin]

Hey crew, I understand you all have day jobs etc and that this isn't priority one for you. It's been a number of weeks, any chance I could get eyes on this? 😀

[kingthorin]

@ibakshay sorry to be pushy, I know ppl are busy with life. But, this would really help us and hopefully others too.

[ibakshay]

@kingthorin, I apologise for a LATE response. i was on vacation during August and then life happened.
I really appreciate your PR! I tested in my test repository and I found out that the fix doesn't work as expected. I am getting an error - link to the test workflow run.

Tip:
You have to add an if check in these two places.

1. github-action/src/pullrequest/pullRequestCommentContent.ts

   Line 54 in f419467

   text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the ****DCO Assistant Lite bot****.</sub>'

2. github-action/src/pullrequest/pullRequestCommentContent.ts

   Line 96 in f419467

   text += '<sub>You can retrigger this bot by commenting **recheck** in this Pull Request. Posted by the **CLA Assistant Lite bot**.</sub>'

[kingthorin]

Thanks I'll get those adjusted too!

[kingthorin]

Hopefully that's it 😀

[ibakshay]

Hopefully that's it 😀

You should also add the input to this action.yml file :)
https://github.com/contributor-assistant/github-action/blob/master/action.yml

[kingthorin]

No problem, thanks for your help

[kingthorin]

Addressed.

[ibakshay]

Addressed.

thanks a lot. Could you please do npm run buildand then push again?
You will see some changes in dist/index.js after you did npm run build. @kingthorin

[kingthorin]

Yup I'll have to setup a Linux image, I was doing this all via GitHub.dev

[kingthorin]

I was able to do it in a CodeSpace 😀 Hopefully that looks as you expected?

[ibakshay]

I was able to do it in a CodeSpace 😀 Hopefully that looks as you expected?

It works great. Thanks so much for your contribution! I really appreciate it very much 🚀

[ibakshay]

🚀

[kingthorin]

Thanks for helping move this along. Sadly a colleague pointed out this may have broken things because the bot “signature” is left off but used as a condition elsewhere.

github-action/src/pullrequest/pullRequestComment.ts

Lines 64 to 67 in 0fb6942

	if (getUseDcoFlag() === 'true') {
	return response.data.find(comment => comment.body.match(/.*DCO Assistant Lite bot.*/m))
	} else if (getUseDcoFlag() === 'false') {
	return response.data.find(comment => comment.body.match(/.*CLA Assistant Lite bot.*/m))

I’ll get a fix PR in today.