Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DATABASE_URL where possible #4862

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove DATABASE_URL where possible #4862

wants to merge 3 commits into from

Conversation

foarsitter
Copy link
Collaborator

@foarsitter foarsitter commented Feb 15, 2024 •
edited
Loading

This is an attempt the remove DATABASE_URL environment variable.

The only use case where DATABASE_URL is required is when an application is hosted on heroku.

@foarsitter foarsitter marked this pull request as ready for review August 27, 2024 08:44
@foarsitter foarsitter mentioned this pull request Aug 27, 2024
Closed
@foarsitter foarsitter changed the title Remove DATABASE where possible Remove DATABASE_URL where possible Aug 27, 2024
@foarsitter foarsitter mentioned this pull request Aug 28, 2024
Closed
@foarsitter foarsitter requested review from browniebroke and removed request for browniebroke October 11, 2024 07:54
browniebroke
browniebroke reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle, might be nice to see how it looks like after master is merged, as there was a few other changes

{{cookiecutter.project_slug}}/.github/workflows/ci.yml Outdated Show resolved Hide resolved
docs/developing-locally.rst Outdated Show resolved Hide resolved
docs/developing-locally.rst Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/config/settings/base.py Outdated Show resolved Hide resolved
foarsitter and others added 2 commits October 14, 2024 20:42
@foarsitter @browniebroke
Update {{cookiecutter.project_slug}}/config/settings/base.py
6e6d327 
Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
@foarsitter
Updated with PR feedback
ed50445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@browniebroke browniebroke browniebroke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foarsitter @browniebroke