Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coq-freesim 1.0.0 #2728

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Add coq-freesim 1.0.0 #2728

merged 4 commits into from
Sep 19, 2023

Conversation

alxest
Copy link
Contributor

@alxest alxest commented Sep 17, 2023

No description provided.

palmskog
palmskog reviewed Sep 17, 2023
View reviewed changes
Copy link
Contributor

@palmskog palmskog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the file name from FreeSim.opam to just opam, otherwise it won't work.

released/packages/coq-freesim/coq-freesim.1.0.0/FreeSim.opam Outdated Show resolved Hide resolved
released/packages/coq-freesim/coq-freesim.1.0.0/FreeSim.opam Outdated Show resolved Hide resolved
@alxest
Copy link
Contributor Author

alxest commented Sep 17, 2023

@palmskog Thank you for the suggestions. I have fixed the mentioned issues.
The CI is still failing with errors, but I am not sure what these errors means. Can you help me reading these errors?

@silene
Copy link
Contributor

silene commented Sep 18, 2023

Your opam file indicates no source file. It should at least mention that Opam needs to download the following archive https://github.com/CCR-project/FreeSim/archive/refs/tags/AE.tar.gz (or some other archive if it is not the proper one).

palmskog
palmskog reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@palmskog palmskog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If AE is the tag you want to use, this is what you need to add to enable opam to fetch and build the archive.

released/packages/coq-freesim/coq-freesim.1.0.0/opam Show resolved Hide resolved
@palmskog palmskog merged commit 940a5b1 into coq:master Sep 19, 2023
3 checks passed
@alxest
Copy link
Contributor Author

alxest commented Oct 16, 2023

@silene @palmskog Thank you for figuring out the issue and fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palmskog palmskog palmskog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxest @silene @palmskog