This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
[WIP] CRD Spec: add option to configure HostNetwork and DNSPolicy #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
can you please verify the patch. I am guessing the jenkins will trigger only after one of the admin 'verifies' the patch. I have not added tests yet, as I was not sure if its safe to run e-2-e and unit tests on my laptop and was hoping to leverage ci on this project. Many thanks in advance. Thanks |
|
Hi @hasbro17 could you please verify and allow testing this patch Many Thanks |
this allows the network plugins like CNI to use etcd-cluster as kv when bootstrapping the cluster fixes coreos#1929
|
Hi @hexfusion can you please mark this PR to be tested via Jenkins? if we find issues during that, I want to make sure I push fixes for it right away. Thanks |
|
@hongchaodeng It would be nice if this gets released. 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows the network plugins like Cilium CNI to use etcd-cluster
as kv store when bootstrapping the cluster
fixes #1929