cleaned up deprecated linting rules, fixed a bunch of minor linting w…

…arnings

.eslintrc.json

@@ -22,28 +22,24 @@
     "sourceType": "module"
   },
   "rules": {
-    "camelcase": "warn",
+    "camelcase": "off",
     "explicit-function-return-type": "off",
     "no-empty-function": "warn",
     "import/prefer-default-export": "off",
     "consistent-return": "warn",
     "guard-for-in": "warn",
     "import/extensions": "off",
-    "max-len": ["warn", 160],
     "new-cap": "warn",
-    "quotes": "off",
     "no-await-in-loop": "warn",
     "no-continue": "off",
     "no-nested-ternary": "off",
     "no-plusplus": "off",
     "no-prototype-builtins": "warn",
-    "no-return-await": "off",
     "no-shadow": "warn",
     "no-underscore-dangle": "off",
     "no-unused-vars": "warn",
     "no-undef": "warn",
     "no-var": "error",
-    "object-curly-newline": "off",
     "react/prop-types": "warn",
     "react/no-string-refs": "warn",
     "react/no-deprecated": "warn"

client/src/auth/auth_utils.ts

@@ -70,9 +70,9 @@ export function useAuthMandatoryLogin(redirectFrom: string): {
       history.push('/login')
     }
 
-    const token = getAuthToken()
+    const authToken = getAuthToken()
 
-    if (!token || token === '') {
+    if (!authToken || authToken === '') {
       signIn(redirectFrom)
     } else {
       axios
@@ -88,7 +88,7 @@ export function useAuthMandatoryLogin(redirectFrom: string): {
         .catch((e) => console.log(e.response))
     }
 
-    setToken(token)
+    setToken(authToken)
     setIsAuthenticating(false)
     setIsLoggedIn(true)
   }, [redirectFrom, history])

client/src/modules/Admin/Components/AdminReview.tsx

@@ -1,4 +1,4 @@
-import React, { useEffect, useState } from 'react'
+import React, { useState } from 'react'
 import axios from 'axios'
 import styles from '../Styles/AdminReview.module.css'
 

client/src/modules/Admin/Components/AdminUser.tsx

@@ -1,5 +1,4 @@
-import React, { useEffect, useState } from 'react'
-import axios from 'axios'
+import React from 'react'
 import styles from '../Styles/AdminUser.module.css'
 
 type Props = {

client/src/modules/Admin/Components/Stats.tsx

@@ -1,7 +1,6 @@
 import React, { useEffect, useState } from 'react'
 import axios from 'axios'
 import styles from '../Styles/Stats.module.css'
-import { Review } from 'common'
 
 type StatsProps = {
     token: string

client/src/modules/AuthRedirect/Components/AuthRedirect.tsx

@@ -19,12 +19,12 @@ Saves Google ID Token from URL parameters when Google redirects user back to thi
 
 export const AuthRedirect = ({location}: Props) => {
 
-  const google_hash = location.hash
-  if (google_hash !== '') {
-    const google_token = google_hash
+  const googleHash = location.hash
+  if (googleHash !== '') {
+    const googleToken = googleHash
       .match(/(?=id_token=)([^&]+)/)![0]
       .split('=')[1]
-    setAuthToken(google_token)
+    setAuthToken(googleToken)
   }
 
   if (Session.get('redirectFrom') === 'course') {

client/src/modules/Course/Components/CourseReviews.tsx

@@ -1,6 +1,6 @@
 import React, { useState } from 'react'
 import axios from 'axios'
-import { toast, ToastContainer } from 'react-toastify'
+import { toast } from 'react-toastify'
 import 'react-toastify/dist/ReactToastify.css'
 
 import ReviewCard from './ReviewCard'

client/src/modules/Course/Components/Feedback.js

@@ -1,7 +1,7 @@
 /* globals gtag */
 export function courseVisited(classSub, classNum) {
   gtag('event', 'Course Visited', {
-    event_category: 'Courses Visited',
-    event_label: classSub + classNum,
+    eventCategory: 'Courses Visited',
+    eventLabel: classSub + classNum,
   })
 }

client/src/modules/Course/Components/PreviewReviewCard.tsx

@@ -38,7 +38,7 @@ export default function PreviewReviewCard({
   review,
   isPreview,
   isProfile,
-}: ReviewProps): JSX.Element {
+}: ReviewProps): React.JSX.Element {
   const { isLoggedIn } = useAuthOptionalLogin()
   const pending = isPreview && isProfile
 
@@ -55,11 +55,11 @@ export default function PreviewReviewCard({
     if (!_review.date) return ''
 
     const date = new Date(_review.date)
-    let review_year = String(date.getFullYear()).substring(2)
-    let review_month = date.getMonth() + 1
-    let review_day = date.getDate()
+    let reviewYear = String(date.getFullYear()).substring(2)
+    let reviewMonth = date.getMonth() + 1
+    let reviewDay = date.getDate()
 
-    return review_month + '/' + review_day + '/' + review_year
+    return reviewMonth + '/' + reviewDay + '/' + reviewYear
   }
 
   /**

client/src/modules/Home/Components/Home.tsx

@@ -29,20 +29,20 @@ export const Home = () => {
 
   /** Logic for deciding the home pages' background image */
   function setBackground() {
-    const sunset_start_times = [
+    const sunsetStartTimes = [
       17.0, 17.5, 18, 19.5, 20, 20.5, 20.5, 19.5, 18.5, 18, 16.5, 16.5,
     ]
-    const sunset_end_times = [
+    const sunsetEndTimes = [
       18.5, 19, 20.5, 21, 22, 22, 22, 21.5, 20.5, 20, 19, 18,
     ]
     const date = new Date()
     const month = date.getMonth()
     const hours = date.getHours()
     const minutes = date.getMinutes()
 
-    let time_of_day = hours
+    let timeOfDay = hours
     if (minutes > 30) {
-      time_of_day += 0.51
+      timeOfDay += 0.51
     }
     if (month === 11 || month === 0 || month === 1) {
       setSeason('winter')
@@ -54,9 +54,9 @@ export const Home = () => {
       setSeason('fall')
     }
 
-    if (time_of_day < 6 || time_of_day >= sunset_end_times[month]) {
+    if (timeOfDay < 6 || timeOfDay >= sunsetStartTimes[month]) {
       setTime('night')
-    } else if (time_of_day >= sunset_start_times[month]) {
+    } else if (timeOfDay >= sunsetEndTimes[month]) {
       setTime('sunset')
     }
   }

client/src/modules/Results/Components/FilteredResult.tsx

@@ -11,12 +11,6 @@ type Props = {
   sortBy: 'rating' | 'relevance' | 'diff' | 'work'
 }
 
-type State = {
-  course: Class
-  current_index: number
-  sortBy: string
-}
-
 /**
   Filtered Result Component.
 

client/src/modules/Results/Components/ResultsDisplay.jsx

@@ -26,8 +26,8 @@ export default class ResultsDisplay extends Component {
     super(props)
     this.state = {
       courseList: this.props.courses,
-      card_course: this.props.courses[0],
-      active_card: 0,
+      cardCourse: this.props.courses[0],
+      activeCard: 0,
       selected: props.type === 'major' ? 'rating' : 'relevance',
       filters: {
         Fall: true,
@@ -65,7 +65,7 @@ export default class ResultsDisplay extends Component {
         {
           courseList: this.props.courses,
           relevantCourseList: this.props.courses,
-          card_course: this.props.courses[0],
+          cardCourse: this.props.courses[0],
         },
         () => this.filterClasses()
       )
@@ -124,8 +124,8 @@ export default class ResultsDisplay extends Component {
     })
     this.setState({
       filteredItems: courseList,
-      card_course: courseList[0],
-      active_card: 0,
+      cardCourse: courseList[0],
+      activeCard: 0,
     })
   }
 
@@ -183,12 +183,12 @@ export default class ResultsDisplay extends Component {
       )
     )
 
-    let subjects_objects = this.state.filterMap.get('subjects')
-    if (subjects_objects && subjects_objects.length > 0) {
+    let subjectsObjects = this.state.filterMap.get('subjects')
+    if (subjectsObjects && subjectsObjects.length > 0) {
       filteredItems = filteredItems.filter((course) =>
-        subjects_objects.some(
-          (subject_object) =>
-            course.classSub.toUpperCase() === subject_object.value
+        subjectsObjects.some(
+          (subjectObject) =>
+            course.classSub.toUpperCase() === subjectObject.value
         )
       )
     }
@@ -213,8 +213,8 @@ export default class ResultsDisplay extends Component {
   //if the course's [index] in the list of FilteredResult components is clicked
   previewHandler(course, index) {
     this.setState({
-      card_course: course,
-      active_card: index,
+      cardCourse: course,
+      activeCard: index,
     })
     this.setState({ transformGauges: false })
   }
@@ -250,7 +250,7 @@ export default class ResultsDisplay extends Component {
         <FilteredResult
           key={index}
           index={index}
-          selected={index === this.state.active_card}
+          selected={index === this.state.activeCard}
           course={result}
           previewHandler={this.previewHandler}
           sortBy={this.state.selected}
@@ -260,8 +260,8 @@ export default class ResultsDisplay extends Component {
   }
 
   renderCheckboxes(group) {
-    let group_list = Array.from(this.state.filterMap.get(group).keys())
-    return group_list.map((name, index) => (
+    let groupList = Array.from(this.state.filterMap.get(group).keys())
+    return groupList.map((name, index) => (
       <div className = {styles.filterlabel}>
         <label className={styles.filterlabel}>
           <input
@@ -402,7 +402,7 @@ export default class ResultsDisplay extends Component {
                 </div>
                 <div className={styles.preview}>
                   <PreviewCard 
-                    course={this.state.card_course}
+                    course={this.state.cardCourse}
                     transformGauges = {this.state.transformGauges} />
                 </div>
               </div>

client/src/modules/SearchBar/Components/ProfessorResult.tsx

@@ -1,4 +1,4 @@
-import React, { Component } from 'react'
+import React from 'react'
 import '../Styles/Course.css'
 import { Redirect } from 'react-router'
 import { Professor } from 'common'

client/src/modules/SearchBar/Components/SearchBar.tsx

@@ -153,8 +153,6 @@ export const SearchBar = ({
   const renderResults = () => {
     /** Only render if the query is not empty */
     if (query !== '' && !selected) {
-      let results = []
-
       /* User press [ENTER] button?
             => Redirect user to '/results/keyword/query+query'
        */

client/src/modules/SearchBar/Components/SubjectResult.tsx

@@ -1,4 +1,4 @@
-import React, { Component } from 'react'
+import React from 'react'
 import '../Styles/Course.css'
 import { Redirect } from 'react-router'
 import { Subject } from 'common'