-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymous warning modal #458
Conversation
[diff-counting] Significant lines: 268. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this feature! The UI looks super clean and I can't wait to see it on the deployed website! I added some comments of some bugs/fixes I found through my testing :)
Login | ||
</button> | ||
<div className={styles.pastReviewsMessage}> | ||
You will be redirected to your past reviews page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this feature Andrew! I think it works pretty smoothly. Just gotta fix the merge conflicts and which endpoints the frontend is hitting.
Summary
This PR works on the anonymous warning feature, and fixes a bug with the admin management modal. @leihelen did most of the heavy lifting on implementing the anonymous modal on the front-end, I mainly finished integrating the feature and adding the backend functionality we want.
PR Type
Mobile + Desktop Screenshots & Recordings
QA - Test Plan
I tested the functionality in three cases:
Breaking Changes & Notes
Added to documentation?
What GIF represents this PR?
gif