Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(x/bank): use a more flexible value codec for bank's denom address index. #16772

Closed
Tracked by #16505
testinginprod opened this issue Jun 29, 2023 · 2 comments · Fixed by #16841
Closed
Tracked by #16505

fix(x/bank): use a more flexible value codec for bank's denom address index. #16772

testinginprod opened this issue Jun 29, 2023 · 2 comments · Fixed by #16841
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/bank

Comments

@testinginprod
Copy link
Contributor

Requires: #16771

After migrating bank to collections, even if it does not show up in code, collections will complain if there's some path that requires reading the index value of bank's denom address index. This never happens because we only care about keys (the denom to address index is represented as a key, with a meaningless value), nonetheless in order to protect forward compatibility we should add a more flexible value codec that accepts values != []byte{} and lazily migrates them to []byte{}.

@testinginprod testinginprod added C:x/bank backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release labels Jun 29, 2023
@likhita-809
Copy link
Contributor

@testinginprod should this be completed as part of bank audit ?

@testinginprod
Copy link
Contributor Author

@likhita-809 : yes, I will open a PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/bank
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants