Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): add missing modules from swagger #17051

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

Closes: #17013


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 18, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner July 18, 2023 18:50
@@ -396,7 +396,7 @@ lint-fix:
### Protobuf ###
###############################################################################

protoVer=0.13.4
protoVer=0.13.5
Copy link
Member Author

@julienrbrt julienrbrt Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be tagging proto-builder after this PR.
I added jq as it is useful to have in the container (in case we want to improve the protoc-gen-swagger script and need to read that config file).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tac0turtle tac0turtle added this pull request to the merge queue Jul 18, 2023
Merged via the queue into main with commit 1d74652 Jul 18, 2023
42 of 43 checks passed
@tac0turtle tac0turtle deleted the julien/audit-client branch July 18, 2023 21:16
mergify bot pushed a commit that referenced this pull request Jul 18, 2023
(cherry picked from commit 1d74652)

# Conflicts:
#	Makefile
julienrbrt added a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit client v0.47..v0.50
2 participants